Fix the private field crash for the Array object. #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good patch. Please add the testcase. |
Added. |
|
Please squash the commits and add DCO to the commit message. |
paintedveil5
force-pushed
the
fix-private-field
branch
2 times, most recently
from
c7dcf9a
to
2c0f9d2
Compare
akosthekiss
requested changes
May 7, 2024
JerryScript-DCO-1.0-Signed-off-by: Baihe Jiang <[email protected]>
paintedveil5
force-pushed
the
fix-private-field
branch
from
04beb27
to
411a949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the private field crash in the Array object mentioned in
#5138