Skip to content

Commit

Permalink
Fix CI for macos
Browse files Browse the repository at this point in the history
Roll back macos version used by github actions from `macos-latest`
(`macos-14`) to `macos-13`.

Due to compiler bugs present in the latest version of clang on macos:
    1. Some modulo operations were failing, such as `-1 % -1` when
       compiler optimizations were enabled
    2. `-Wliteral-range` was falsely raised for `isnan`, `isinf`,
       and `isfinite` macros in `test-math.c`

JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi [email protected]
  • Loading branch information
matetokodi committed May 23, 2024
1 parent 47bd5d4 commit 1425b4b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/gh-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- run: $RUNNER -q --jerry-tests --buildoptions=--compile-flag=-m32,--cpointer-32bit=on --build-debug

OSX_x86-64_Build_Correctness_Unit_Tests:
runs-on: macos-latest
runs-on: macos-13
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v4
Expand All @@ -67,7 +67,7 @@ jobs:
- run: $RUNNER -q --unittests

OSX_x86-64_Build_Correctness_Unit_Tests_Debug:
runs-on: macos-latest
runs-on: macos-13
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v4
Expand Down

0 comments on commit 1425b4b

Please sign in to comment.