fix: improve error handling (#65)

resolves #64
jeremylong · Aug 16, 2023 · 4c6b8b2 · 4c6b8b2
1 parent 32fb9b5
commit 4c6b8b2
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/vulnz/src/main/java/io/github/jeremylong/vulnz/cli/commands/CveCommand.java b/vulnz/src/main/java/io/github/jeremylong/vulnz/cli/commands/CveCommand.java
@@ -201,9 +201,14 @@ public Integer timedCall() throws Exception {
             if (configGroup.cacheSettings.prefix != null) {
                 properties.set("prefix", configGroup.cacheSettings.prefix);
             }
-            int status = processRequest(builder, properties);
-            properties.save();
-            return status;
+            try {
+                int status = processRequest(builder, properties);
+                properties.save();
+                return status;
+            } catch (CacheException ex) {
+                LOG.error(ex.getMessage());
+            }
+            return 1;
         }
         if (configGroup != null && configGroup.modifiedRange != null
                 && configGroup.modifiedRange.lastModStartDate != null) {
@@ -248,7 +253,8 @@ private Integer processRequest(NvdCveClientBuilder builder, CacheProperties prop
                 lastModified = api.getLastUpdated();
             }
         } catch (Exception ex) {
-            LOG.error("\nERROR", ex);
+            LOG.debug("\nERROR", ex);
+            throw new CacheException("Unable to complete NVD cache update due to error: " + ex.getMessage());
         }
         if (lastModified != null) {
             properties.set("lastModifiedDate", lastModified);
@@ -269,7 +275,7 @@ private Integer processRequest(NvdCveClientBuilder builder, CacheProperties prop
             try {
                 objectMapper.writeValue(file, data);
             } catch (IOException ex) {
-                throw new CacheException("Unable to read cached data: " + file, ex);
+                throw new CacheException("Unable to write cached data: " + file, ex);
             }
         }
         return 0;