Skip to content

Commit

Permalink
fix: pin bahmutov/npm-install version
Browse files Browse the repository at this point in the history 
v1.8.16 breaks cache miss installs on windows, which blocks any PRs/commits
that change dependencies. Opened bahmutov/npm-install#146
to address the underlying issue, but in the meantime we can pin to the prior
version to get things working again.

Additional context:
- Discord: https://discord.com/channels/770287896669978684/940264701785423992/991085961972707338
- Initial PR affected: remix-run#2027
- Repro/Debug PR: remix-run#3584
  • Loading branch information
@jenseng
jenseng committed Jun 28, 2022
1 parent 1dfae95 commit 9716a58
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 21 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/deployments.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
working-directory: ./scripts/deployment-test

- name: 📥 Install deployment-test deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/deployment-test
useLockFile: false
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
working-directory: ./scripts/deployment-test

- name: 📥 Install deployment-test deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/deployment-test
useLockFile: false
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
working-directory: ./scripts/deployment-test

- name: 📥 Install deployment-test deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/deployment-test
useLockFile: false
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
working-directory: ./scripts/deployment-test

- name: 📥 Install deployment-test deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/deployment-test
useLockFile: false
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:
working-directory: ./scripts/deployment-test

- name: 📥 Install deployment-test deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/deployment-test
useLockFile: false
Expand Down Expand Up @@ -245,7 +245,7 @@ jobs:
working-directory: ./scripts/deployment-test

- name: 📥 Install deployment-test deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/deployment-test
useLockFile: false
Expand Down Expand Up @@ -280,7 +280,7 @@ jobs:
working-directory: ./scripts/deployment-test

- name: 📥 Install deployment-test deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/deployment-test
useLockFile: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

- name: 🔗 Convert Docs links to references
run: node scripts/markdown-references.mjs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

- name: ⤴️ Update Version if needed
id: version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-comments.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ./scripts/release

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-private.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

- name: 🏗 Build
run: yarn build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

- name: 🏗 Build
run: yarn build
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/reusable-test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

- name: 🏗 Build
run: yarn build
Expand All @@ -53,7 +53,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

- name: 🔬 Lint
run: yarn lint
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

- name: 🧪 Run Primary Tests
run: "yarn test:primary"
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
- name: 📥 Install deps
# even though this is called "npm-install" it does use yarn to install
# because we have a yarn.lock and caches efficiently.
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15

# playwright recommends if you cache the binaries to keep it tied to the version of playwright you are using.
# https://playwright.dev/docs/ci#caching-browsers
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/stacks.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
npx -y create-remix@${{ inputs.version }} ${{ matrix.stack.name }} --template ${{ matrix.stack.repo }} --typescript --no-install
- name: 📥 Download deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ${{ matrix.stack.name }}
useLockFile: false
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
run: unzip ${{ matrix.stack.name }}.zip

- name: 📥 Download deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ${{ matrix.stack.name }}

Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
run: unzip ${{ matrix.stack.name }}.zip

- name: 📥 Download deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ${{ matrix.stack.name }}

Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
run: unzip ${{ matrix.stack.name }}.zip

- name: 📥 Download deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ${{ matrix.stack.name }}

Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:
run: unzip ${{ matrix.stack.name }}.zip

- name: 📥 Download deps
uses: bahmutov/npm-install@v1
uses: bahmutov/npm-install@v1.8.15
with:
working-directory: ${{ matrix.stack.name }}

Expand Down

0 comments on commit 9716a58

Please sign in to comment.