Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user config CA and tls #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow user config CA and tls #33

wants to merge 2 commits into from

Conversation

fengxx
Copy link

@fengxx fengxx commented Mar 13, 2023

@olivergondza please help test this PR

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@fengxx fengxx mentioned this pull request Mar 13, 2023
3 tasks
@olivergondza
Copy link
Member

Thanks for looking into this!

Personally, I do not see the use-case that would motivate making this configurable on a per-service level. Java do have a mechanism to trust certificates of services it integrates with - the truststore. You do not have to do anything on the implementation side, and admins can add splunk cert if needed in a conventional way.

I do not feel strongly whether to additionally enable Splunk cert management in UI, but I strongly encourage it should default to java truststore if not specified.

@fengxx
Copy link
Author

fengxx commented May 5, 2023

yes, it default to JDK trustStore but allows user to add extra CA, just like curl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants