Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.452.4 or newer #38

Merged

Conversation

jonesbusy
Copy link
Contributor

Hello label-verifier developers!

This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:

Upgrade to latest recommended core version and ensure the bom is matching the core version

io.jenkins.tools.pluginmodernizer.UpgradeToRecommendCoreVersion

Upgrade to latest recommended core version and ensure the bom is matching the core version

@jonesbusy jonesbusy requested a review from a team as a code owner December 5, 2024 05:03
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Dec 5, 2024
@MarkEWaite MarkEWaite changed the title Applied recipes UpgradeToRecommendCoreVersion Require Jenkins 2.452.4 or newer Dec 5, 2024
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Dec 5, 2024

I updated the pull request title so that it is focused on the user rather than focused on the action of the tool. When the user reads the changelog, they will understand "Require Jenkins 2.452.4 or newer". They won't understand "Applied recipes".

I also added the "chore" label because I consider this a maintenance task that should not generate a new release of the plugin. The next time there is a release of the plugin, it should be included.

@MarkEWaite MarkEWaite merged commit 8e1e307 into jenkinsci:master Dec 5, 2024
17 checks passed
@jonesbusy jonesbusy deleted the plugin-modernizer-tool branch December 5, 2024 05:57
@jonesbusy
Copy link
Contributor Author

Thanks, sure feel free to adapt.

For the PR title it must be improved I agree. Some month ago we added templating (https://github.com/jenkins-infra/plugin-modernizer-tool/blob/main/plugin-modernizer-core/src/main/jte/pr-title.jte) so it should be quite easy to change this and include different information

The tool also try to add labels when applying recipes (https://github.com/jenkins-infra/plugin-modernizer-tool/blob/main/plugin-modernizer-core/src/main/resources/META-INF/rewrite/recipes.yml#L123) but it only work when the use has write access (which I don't in this case).

Perhaps it could be part of the PR body like ("Recommanded labels")

Such feedback is important and I hope also we could gather more during the contributor submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants