Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GPG key #144

Merged
merged 7 commits into from
Apr 12, 2023
Merged

chore: update GPG key #144

merged 7 commits into from
Apr 12, 2023

Conversation

yanksyoon
Copy link
Collaborator

@yanksyoon yanksyoon commented Apr 6, 2023

This PR updates the GPG key to refresh the expired GPG key as per https://www.jenkins.io/blog/2023/03/27/repository-signing-keys-changing/.

The issue with xenial failing is fixed by pinning the charm-tools version to 2.x. canonical/layer-basic#212.

The runner has been updated to run on ubuntu-latest since Github has deprecated 18.04 runner images.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@yanksyoon yanksyoon changed the title [WIP] chore: update GPG key chore: update GPG key Apr 6, 2023
@yanksyoon yanksyoon marked this pull request as ready for review April 6, 2023 07:43
@yanksyoon yanksyoon marked this pull request as draft April 6, 2023 08:28
@yanksyoon yanksyoon marked this pull request as ready for review April 6, 2023 11:33
jdkandersson
jdkandersson previously approved these changes Apr 11, 2023
.github/workflows/integration_test.yaml Outdated Show resolved Hide resolved
weiiwang01
weiiwang01 previously approved these changes Apr 11, 2023
@yanksyoon yanksyoon dismissed stale reviews from weiiwang01 and jdkandersson via ecf02f3 April 11, 2023 07:05
weiiwang01
weiiwang01 previously approved these changes Apr 11, 2023
Copy link
Collaborator

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanksyoon yanksyoon dismissed stale reviews from gregory-schiano and weiiwang01 via ae71285 April 12, 2023 01:31
@yanksyoon yanksyoon merged commit 95f27ee into master Apr 12, 2023
@yanksyoon yanksyoon deleted the fix/gpg branch April 12, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants