Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache Commons Text to dependencies list #335

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

charles-toller
Copy link

@charles-toller charles-toller commented Aug 22, 2024

Use of StringSubstitutor without a dependency on the Apache Commons Text library causes a ClassNotFoundException on a fresh Jenkins install. This PR adds that dependency to the pom.xml file to alleviate this issue.

Testing done

Automated CI checks; also tested on a fresh Jenkins instance and it resolves the issue listed above.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@charles-toller charles-toller marked this pull request as ready for review August 22, 2024 22:14
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct; it should be using https://github.com/jenkinsci/commons-text-api-plugin
which is a part of the bom so you do not need to specify version.
This is to avoid version conflicts between commons-text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants