use UTF_8 when converting error response (#50)

jenkinsci · Aug 28, 2019 · e576658 · e576658
1 parent 63f634a
commit e576658
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -175,7 +175,7 @@ unclassified:
   hashicorpVault:
     configuration:
       vaultCredentialId: "vaultToken"
-      vaultUrl: "${CASC_VAULT_AGENT_ADDR:-http://localhost:8100}" # Vault Agent Addr
+      vaultUrl: "https://vault.company.io"
 
 credentials:
   system:

diff --git a/src/main/java/com/datapipe/jenkins/vault/VaultBuildWrapper.java b/src/main/java/com/datapipe/jenkins/vault/VaultBuildWrapper.java
@@ -55,6 +55,7 @@
 import hudson.security.ACL;
 import hudson.tasks.BuildWrapperDescriptor;
 import java.io.PrintStream;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -183,14 +184,13 @@ private void parseVaultErrorCodes(String path, LogicalResponse response) {
             }
         } else if (status >= 400) {
             String errors = Optional
-                .of(Json.parse(new String(restResponse.getBody()))).map(JsonValue::asObject)
+                .of(Json.parse(new String(restResponse.getBody(), StandardCharsets.UTF_8))).map(JsonValue::asObject)
                 .map(j -> j.get("errors")).map(JsonValue::asArray).map(JsonArray::values)
                 .map(j -> j.stream().map(JsonValue::asString).collect(Collectors.joining("\n")))
                 .orElse("");
             logger.printf("Vault responded with %d error code.%n", status);
             if (StringUtils.isNotBlank(errors)) {
-                logger.printf("Vault responded with errors: %s%n",
-                    new String(restResponse.getBody()));
+                logger.printf("Vault responded with errors: %s%n", errors);
             }
         }
     }