Improve assertion message for Windows failure diagnosis

jenkinsci · Jan 22, 2025 · f092c69 · f092c69
1 parent 4144978
commit f092c69
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/src/test/java/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinitionTest.java b/src/test/java/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinitionTest.java
@@ -1057,13 +1057,30 @@ private SCM getGitSCM(String... urls) {
         return new GitSCM(configs, null, null, null, null);
     }
 
+    private String itemValues(ItemsErrorModel items) {
+        String values = "";
+        for (int i = 0; i < items.size(); i++) {
+            values = values + " " + items.get(i).value;
+        }
+        return values;
+    }
+
+    private String itemNames(ItemsErrorModel items) {
+        String names = "";
+        for (int i = 0; i < items.size(); i++) {
+            names = names + " " + items.get(i).name;
+        }
+        return names;
+    }
+
     private boolean isListBoxItem(ItemsErrorModel items, String item) {
         boolean itemExists = false;
         for (int i = 0; i < items.size(); i++) {
             if (items.get(i).value.contains(item)) {
                 itemExists = true;
             }
         }
+        assertTrue("Item '" + item + "' not found in values '" + itemValues(items) + "'", itemExists);
         return itemExists;
     }
 
@@ -1074,6 +1091,7 @@ private boolean isListBoxItemName(ItemsErrorModel items, String item) {
                 itemExists = true;
             }
         }
+        assertTrue("Item '" + item + "' not found in names '" + itemNames(items) + "'", itemExists);
         return itemExists;
     }
 }