-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-64844] Provide credentials during checkout #1131
base: master
Are you sure you want to change the base?
[JENKINS-64844] Provide credentials during checkout #1131
Conversation
@MarkEWaite can you give me some hints about the failures? |
Hi everyone, Is there any news here yet? My employer would also be very interested in this extension. |
No news from me. I think that the change is moving on the correct path, since it is following the same pattern that was used to add credentials to the @mischoem even if you can't investigate the test failures, it would be very good for you to deploy an incremental build of this pull request in your environment and share your results. That would give you immediate access to the feature and would provide feedback to me and other maintainers to confirm that the code is working as desired in production |
A little feedback from my side: After testing it seems to work fine |
c4765ab
to
c8a729f
Compare
c8a729f
to
af080b9
Compare
JENKINS-64844 - Provide credentials during checkout
Start support for partially cloned repos
This is a first draft for review to allow to perform checkout using credentials as required for instance when using a blobless clone. Hints about a better way to retrieve the checkout url or to the kind of unit tests that would be possible are welcome.
Checklist
Types of changes
What types of changes does your code introduce?
Further comments
This is not a complete support for blobless clone, just enough for our case (checkout scm occurs on Kubernetes in an image already containing a max one day old blobless clone of the repo). If something more complete is required to get this support integrated in the code base, please give me some advice on it.