Use same version in BOM as is declared for plugin #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the plugin required Jenkins 2.452.4 but only used plugin BOM dependencies from 2.440.x. Also removes the unnecessary declaration of the httpcomponents-client-5 plugin version since the plugin BOM now includes the correct version. Confirmed that `mvn dependency:tree` reports the same version of httpcomponents-client-5 plugin from the plugin BOM as is currently delivered to users.
|
Sure thing, Mark, thanks for asking. 🤗 |
gounthar
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use same version in BOM as is declared for plugin
Previously the plugin required Jenkins 2.452.4 but only used plugin BOM dependencies from 2.440.x.
Also removes the unnecessary declaration of the httpcomponents-client-5 plugin version since the plugin BOM now includes the correct version.
Replaces pull request:
Testing done
Confirmed that
mvn dependency:treereports the same version of httpcomponents-client-5 plugin from the plugin BOM as is currently delivered to users.Confirmed that automated tests pass.
Submitter checklist