Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71959] Rename blank cloud names to be non-blank #1010

Merged
merged 4 commits into from
Sep 4, 2023

Commits on Sep 3, 2023

  1. [JENKINS-70729] Stop supporting an empty cloud name

    jenkinsci/jenkins#7658 reworks cloud management
    to use multiple pages instead of a single large page.  That rework also
    requires that a cloud may not be named with an empty string.
    
    The docker plugin specifically tested that a cloud was allowed to have an
    empty string as its name, but performed no other operations with a cloud
    that is named with an empty string.  Cloud named with an empty string may
    have worked prior to Jenkins 2.403, but they would have been complicated
    to manage, especially in a controller with multiple clouds defined.
    
    A cloud named with an empty string is much more difficult to manage.
    It is better to mention in the changelog that clouds are no longer
    allowed to have an empty name rather than wrestling with all the ways
    that an empty name will break cloud administration.
    
    https://issues.jenkins.io/browse/JENKINS-70729 is the enhancement request
    that implements the change.
    
    https://issues.jenkins.io/browse/JENKINS-71825 is the bug report for
    the automated test failure that started this investigation.
    MarkEWaite committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    1fc91ca View commit details
    Browse the repository at this point in the history
  2. Log a warning if a DockerCloud name is blank

    Do not break existing usage of blank names, but warn in the log file
    that blank names are no longer supported after Jenkins 2.402.
    
    The Jenkins 2.421 cloud creation UI will not allow a blank name, but
    earlier versions may have allowed it.
    
    Assert the log message for blank or name cloud name
    MarkEWaite committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    1416f89 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    80825c3 View commit details
    Browse the repository at this point in the history
  2. Convert empty or blank name to non-blank in readResolve

    Jenkins 2.403 improves the cloud management user interface.  Each cloud is
    now managed from a separate page.  That separate page requires a non-blank
    name for the cloud.  Jenkins 2.402 and later allowed a blank name.
    
    When a blank name is detected, convert it to a non-blank name based on
    the hashCode of the DockerAPI and templates.
    MarkEWaite committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    57d3010 View commit details
    Browse the repository at this point in the history