Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser for grype report #935

Merged
merged 15 commits into from
Jul 30, 2023
Merged

Add parser for grype report #935

merged 15 commits into from
Jul 30, 2023

Conversation

dtbaum
Copy link
Contributor

@dtbaum dtbaum commented Jul 26, 2023

Testing done

Submitter checklist

@dtbaum
Copy link
Contributor Author

dtbaum commented Jul 26, 2023

This parser parses a grype report, generated by my plugin https://plugins.jenkins.io/grypescanner/.

@uhafner uhafner added the feature New features label Jul 27, 2023
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request!

The code looks good, just some small ideas and questions.

@dtbaum
Copy link
Contributor Author

dtbaum commented Jul 28, 2023

@uhafner Is there an elegant way to customize the severity labels? It would be better to use Low, Medium, High, Critical for severity of vulnerabilites.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #935 (a61d5dd) into master (533ac7e) will increase coverage by 0.01%.
The diff coverage is 96.87%.

@@             Coverage Diff              @@
##             master     #935      +/-   ##
============================================
+ Coverage     92.89%   92.91%   +0.01%     
- Complexity     2323     2333      +10     
============================================
  Files           341      343       +2     
  Lines          6449     6479      +30     
  Branches        668      671       +3     
============================================
+ Hits           5991     6020      +29     
  Misses          262      262              
- Partials        196      197       +1     
Files Changed Coverage Δ
...du/hm/hafner/analysis/registry/ParserRegistry.java 100.00% <ø> (ø)
...ava/edu/hm/hafner/analysis/parser/GrypeParser.java 95.45% <95.45%> (ø)
src/main/java/edu/hm/hafner/analysis/Severity.java 100.00% <100.00%> (ø)
...u/hm/hafner/analysis/registry/GrypeDescriptor.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dtbaum dtbaum requested a review from uhafner July 28, 2023 05:14
@uhafner uhafner changed the title added parser for grype report Add parser for grype report Jul 28, 2023
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@uhafner
Copy link
Member

uhafner commented Jul 28, 2023

@uhafner Is there an elegant way to customize the severity labels? It would be better to use Low, Medium, High, Critical for severity of vulnerabilites.

Currently not. I wanted to make that in the beginning configurable (so the analysis-model has the possibility). But then I noticed in the UI that it will get to complex.

@uhafner uhafner merged commit c2485cd into jenkinsci:master Jul 30, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants