-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parser for grype report #935
Conversation
This parser parses a grype report, generated by my plugin https://plugins.jenkins.io/grypescanner/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request!
The code looks good, just some small ideas and questions.
src/test/java/edu/hm/hafner/analysis/parser/GrypeParserTest.java
Outdated
Show resolved
Hide resolved
@uhafner Is there an elegant way to customize the severity labels? It would be better to use Low, Medium, High, Critical for severity of vulnerabilites. |
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
============================================
+ Coverage 92.89% 92.91% +0.01%
- Complexity 2323 2333 +10
============================================
Files 341 343 +2
Lines 6449 6479 +30
Branches 668 671 +3
============================================
+ Hits 5991 6020 +29
Misses 262 262
- Partials 196 197 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Currently not. I wanted to make that in the beginning configurable (so the analysis-model has the possibility). But then I noticed in the UI that it will get to complex. |
Testing done
Submitter checklist