Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jdk download scripts from jenkinsci/docker #147

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented May 14, 2024

This PR adds the jdk download scripts introduced in jenkinsci/docker#1847 for the controller image, reused in jenkinsci/docker-agent#786 for the agent and inbound agent images, and in jenkinsci/docker-ssh-agent#404 for the SSH agent image.

Having a common source for these scripts will allow adding updatecli manifests in these repositories to track their changes from a single source of trust while controlling their lifecycle independently.

Discussing the location of these scripts with @dduportal, I first proposed the shared pipeline library as it's already configured on every project built on *.ci.jenkins.io. But as they're used only by Docker when building container images it made more sense to put them here.

It would also allow introducing tests for these scripts that could be run from the pipeline of this repo without needing them in all consumer repositories.

@lemeurherve lemeurherve added the enhancement New feature or request label May 14, 2024
@lemeurherve lemeurherve requested a review from a team May 14, 2024 21:32
@dduportal
Copy link
Contributor

Discussing the location of these scripts with @dduportal, I first proposed the shared pipeline library as it's already configured on every project built on *.ci.jenkins.io. But as they're used only by Docker when building container images it made more sense to put them here.

To be precise, the proposal I made to host it in the repository here is that the Jenkins infra also have the same needs but not only on Docker images:

I believe we might have other usages (jenkins-infra/packer-images ? etc.) not defined yet, hence the proposal to move it here instead of pipeline librarie repository or jenkinsci GH org.

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nitpick: as per my comment, the scope is wider then only docker so I would suggest to use a directory named temurin or adoptium. But not a blocker at all!

@lemeurherve lemeurherve merged commit dcc24cd into jenkins-infra:main May 15, 2024
@lemeurherve lemeurherve deleted the helpdesk4029-import-jdk-download-scripts-from-official-docker branch May 15, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants