Remove pass_filenames: false
from pre-commit hook
#376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the vulture pre-commit hook work on the specific files specified by pre-commit and not on the entire repo, I need to override the config it as shown here, with
pass_filenames: true
. I argue that this is a saner default thanpass_filenames: false
, so let's remove it from vulture's pre-commit hook.Related Issue
luminartech/dev-tools#43
Checklist:
pre-commit run --all-files
to format and lint my code.