Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth train movement #35

Open
wants to merge 2 commits into
base: fabric/1.19
Choose a base branch
from

Conversation

pernydev
Copy link

Hiya! This is my first ever PR to a Minecraft mod so I don't know if I did everything right. Thankfully I only had to edit the frontend so it was within my knowledge. The idea was told in #33 so I made it! I hope the code is good and readable enough. Sorry for the extra 3.98 kilobytes it added.

@creeper6530
Copy link

I just built it on my machine using gradlew.bat build, and it crashes right away.

Logs:

@pernydev
Copy link
Author

pernydev commented Oct 8, 2023

I don't see a way adding stuff to the webserver would result in a game crash. This branch is pretty outdated currently which might've caused the problem.

@creeper6530
Copy link

I don't either. Your theory seems believable though, so it might be a good idea to consider syncing your fork.

@creeper6530
Copy link

I just build an up-to-date version, which I created by forking the upstream myself and then merging your fork into mine.

It doesn't crash nor show anything unusual in Minecraft logs, however, there aren't any trains visible on the map, even though the track occupancy and signals do work. The "Trains" list in the top left is empty as well. You can see proof here.

The browser console is chock-full of errors, as seen here. I'm no frontend dev though, so I'll leave the debugging to you.

@pernydev
Copy link
Author

pernydev commented Oct 9, 2023

I didn't consider the trains list at the top and by changing the train variable to a map might've broken it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants