Fix navigation for emby-select element #6509
Open
+3
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
bug
Cloudflare Pages deployment
|
Regression 8456317 If we prevent default action, keyboard navigation won't work.
dmitrylyzo
force-pushed
the
fix-nav-regression
branch
from
bb8a54e to
0f59807
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Don't prevent default action for arrow keys in
emby-select- they will be prevented by keyboard navigation.Issues
Regression #6496
If we prevent default action, keyboard navigation won't work.
Maybe someone has other thoughts on the
keydownevent handling?