Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSubtitles directly on the client side #6428

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

OpenSubtitles directly on the client side #6428

wants to merge 5 commits into from

Conversation

wrgallo
Copy link

@wrgallo wrgallo commented Jan 6, 2025

Changes

  • Adds OpenSubtitles to the client.

gid

@wrgallo wrgallo requested a review from a team as a code owner January 6, 2025 17:47
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Jan 6, 2025 •
edited
Loading

Cloudflare Pages deployment

Latest commit 9bb39d1
Status ✅ Deployed!
Preview URL https://5dcb5a73.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

github-actions[bot]
github-actions bot requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/playback/video/index.js Outdated Show resolved Hide resolved
src/index.jsx Outdated Show resolved Hide resolved
src/plugins/htmlVideoPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/htmlVideoPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/htmlVideoPlayer/plugin.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

@thornbill thornbill added the discussion needed Requires input from the community label Jan 16, 2025
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Jan 22, 2025
@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
discussion needed Requires input from the community merge conflict Conflicts prevent merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wrgallo @jellyfin-bot @thornbill