-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart font streaming for external ASS subtitles #6257
base: master
Are you sure you want to change the base?
Conversation
Cloudflare Pages deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Ah no, I actually messed up with the |
389702b
to
1c7fadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Also refactors the function renderSSaAss to be more parallel and readable and nice...
1c7fadc
to
2c1f90e
Compare
Quality Gate failedFailed conditions |
!! requires jellyfin/jellyfin#12877 -- read that PR for more information and discussion on this feature, to avoid duplicating explanations here
Changes
FontsUrl
should be added next toDeliveryUrl
or notIssues
Closes #5960 old PR by superseding it with this
(also since this is a draft, I didn't test the code yet, will remove this line after I do)