Add 'ask to skip' to media segments

[viown]

(Does not support TV OSes just yet)

The button appears for 6 seconds, and can be shown again by moving the mouse to unhide the OSD panel.

Testing appreciated.

Changes

• Add a "Prompt To Skip" option to media segments
• Display "Next Episode" if it's an outro segment, and the segment exceeds or is equal to the runtime, and if there is a next track.

Screenshots

Issues

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	8cc23f2
Status	✅ Deployed!
Preview URL	https://f68267e6.jellyfin-web.pages.dev
Type	🔀 Preview

View build logs

[nielsvanvelzen]

Would be nice if we kept this implementation consistent with ATV (jellyfin/jellyfin-androidtv#4068):

• Name the action ÄskToSkip"
• Only show for segments with duration of 3 seconds or more
• Auto-hide after 8 seconds
• Skipping does nothing if there is only 1 second left in the segment (just like the normal skip action)

[viown]

Good point. And it already checks for segments <3s.

[dmitrylyzo]

We have UpNextDialog:

jellyfin-web/src/controllers/playback/video/index.js

Lines 669 to 684 in 50dd1fb

	function showComingUpNext(player) {
	import('../../../components/upnextdialog/upnextdialog').then(({ default: UpNextDialog }) => {
	if (!(currentVisibleMenu || currentUpNextDialog)) {
	currentVisibleMenu = 'upnext';
	comingUpNextDisplayed = true;
	playbackManager.nextItem(player).then(function (nextItem) {
	currentUpNextDialog = new UpNextDialog({
	parent: view.querySelector('.upNextContainer'),
	player: player,
	nextItem: nextItem
	});
	Events.on(currentUpNextDialog, 'hide', onUpNextHidden);
	}, onUpNextHidden);
	}
	});
	}

I thought we could extract it as PlaybackSubscriber, but it could be merged to MediaSegmentManager.

[viown]

We have UpNextDialog:

jellyfin-web/src/controllers/playback/video/index.js

Lines 669 to 684 in 50dd1fb

	function showComingUpNext(player) {
	import('../../../components/upnextdialog/upnextdialog').then(({ default: UpNextDialog }) => {
	if (!(currentVisibleMenu || currentUpNextDialog)) {
	currentVisibleMenu = 'upnext';
	comingUpNextDisplayed = true;
	playbackManager.nextItem(player).then(function (nextItem) {
	currentUpNextDialog = new UpNextDialog({
	parent: view.querySelector('.upNextContainer'),
	player: player,
	nextItem: nextItem
	});
	Events.on(currentUpNextDialog, 'hide', onUpNextHidden);
	}, onUpNextHidden);
	}
	});
	}

I thought we could extract it as PlaybackSubscriber, but it could be merged to MediaSegmentManager.

Do you suggest we use the UpNextDialog for all segments or just the "Next Episode" part?

[dmitrylyzo]

Do you suggest we use the UpNextDialog for all segments or just the "Next Episode" part?

🤔 Not for all segments, for sure. I like simple buttons for general case. UpNextDialog should be able to work without segments (I'm leaning more towards a dedicated PlaybackSubscriber), and we need to make sure it doesn't conflict with the segment action buttons.

[viown]

I do like the idea of using the up next dialog over the current "Next Episode" button for outro segments as there is a possibility these could clash with each other currently.

Since I believe this dialog shows up 30s before the runtime, we can keep that behaviour as is, but also show the dialog on outro segments that result in the next track. This won't eliminate the clashing possibility completely, but it's acceptable.

[Shadowghost]

If skipping a segment leads to playing the next episode, I think it's sensible to re-use the dialogue - but with a different text to properly indicate the skipping

[pimw1]

Cloudflare Pages deployment

Latest commit 6ca8311
Status ✅ Deployed!
Preview URL https://3e8577ef.jellyfin-web.pages.dev
Type 🔀 Preview
View build logs

The into skipper works as expected. I don't have media with outro segments, so i have not tested that.

[github-actions]

ESLint doesn't pass. Please fix all ESLint issues.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[solidsnake1298]

Skip prompts work for all segment types. As does the prompt to start the next episode for outro segments.

stale