Add stricter checks for DolbyVision in HEVC #5184
Conversation
Signed-off-by: nyanmisaka <[email protected]>
thornbill
force-pushed
the
strict-dovi-hevc
branch
from
dff1a07 to
113c59f
Compare
|
Cloudflare Pages deployment
|
| @@ -930,7 +938,7 @@ export default function (options) { | |||
| av1VideoRangeTypes += '|HLG'; | |||
| } | |||
|
|
|||
| if (supportsDolbyVision(options)) { | |||
| if (supportsDolbyVision(options) && canPlayDolbyVisionHevc(videoTestElement)) { | |||
There was a problem hiding this comment.
Iirc, canPlayType doesn't always work correctly on some platforms. So we probably shouldn't call canPlayDolbyVisionHevc on Tizen(it doesn't support DV) and webOS.
We need someone to test this on real webOS.
There was a problem hiding this comment.
IIRC Samsung only seems to be focused on promoting their HDR10 Plus, if they enable DolbyVision in the future we could add it back.
There was a problem hiding this comment.
There's some discussion about LG TV that they do have DolbyVision working.
And the mp4box of properly encoded progressive and fMP4 HLS streams should have similar metadata for the player to recognize and trigger DolbyVision.
HLS.js currently does not seem to be able to correctly handle the relationship between dvh1 and hvc1, and will fail if WebOS does not support native HLS.
There was a problem hiding this comment.
There's some discussion about LG TV that they do have DolbyVision working.
My concern is that canPlayType is not reliable. If it works properly on modern webOS (older ones hardly support DV), then no problem.
There was a problem hiding this comment.
I'm wondering how the TV client utilizes this boolean options.supportsDolbyVision? Is there a button I didn't notice?
There was a problem hiding this comment.
There was a problem hiding this comment.
Hey, just chiming in to confirm this works fine on my 2022 webos.
|
Hello. I checked version 1.5.7 hls.js browser of LG webOS does not respond to Dolby Vision. |
|
This change so currently not available in stable branch and therefore not in the We is app. |
Changes
Using
iosandosxversion checking is not reliable. Also Apple has adopted AV1 but hasn't enabled it in HLS yet, so we may need to add checks for DolbyVision in AV1 in the future.