Fix language/subtitle switcher when using gamepad - Backport #4860 #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
bug
Raising the event code `13` (Enter) should be a lot more stable since `0` is just the default and not assigned to any actual key [1]. This keycode also has been standardized early enough to change it at this crucial part of gamepad handling in my opinion. [1] https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode Fixes jellyfin#3755
thornbill
force-pushed
the
backport-4860
branch
from
bbd298c
to
b270d40
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
crobibero
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backports the event code fix from #4860 to the 10.8 release branch
Issues
Fixes #3755