Space bar plays/pauses music in queue view #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gantoine, just for future reference, we don't typically include issue numbers in commit messages / PR titles. We strive to follow these guidelines. Additional details can be found in our docs. Thanks! |
gantoine
changed the title
thornbill
reviewed
Oct 16, 2023
|
Hey thanks for the heads up, I've gone ahead and updated the title. I use it as a way to link the linear/jira/trello ticket to a PR, and I guess it's become a habit lol. I'll give those link a quick read! |
|
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR overrides the behavior of the space bar (when in queue view) to play/pause the player. The behavior and code were essentially lifted from
playback/videobut stripped down to the bare essentials.Issues
Closes #4857