Backport pull request #6276 from jellyfin-web/release-10.10.z

Update plugin category labels Original-merge: 9ff9f05 Merged-by: thornbill <[email protected]> Backported-by: Joshua M. Boniface <[email protected]>
jellyfin · Nov 3, 2024 · acbb626 · acbb626
1 parent fc31479
commit acbb626
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 19 deletions.
diff --git a/src/apps/dashboard/features/plugins/constants/categoryLabels.ts b/src/apps/dashboard/features/plugins/constants/categoryLabels.ts
@@ -0,0 +1,15 @@
+/** A mapping of category names used by the plugin repository to translation keys. */
+export const CATEGORY_LABELS = {
+    Administration: 'HeaderAdmin',
+    Anime: 'Anime',
+    Authentication: 'LabelAuthProvider', // Legacy
+    Books: 'Books',
+    Channel: 'Channels', // Unused?
+    General: 'General',
+    LiveTV: 'LiveTV',
+    Metadata: 'LabelMetadata', // Legacy
+    MoviesAndShows: 'MoviesAndShows',
+    Music: 'TabMusic',
+    Subtitles: 'Subtitles',
+    Other: 'Other'
+};
diff --git a/src/controllers/dashboard/plugins/available/index.js b/src/controllers/dashboard/plugins/available/index.js
@@ -1,12 +1,14 @@
 import escapeHTML from 'escape-html';
 
-import loading from '../../../../components/loading/loading';
-import globalize from '../../../../lib/globalize';
-import '../../../../components/cardbuilder/card.scss';
-import '../../../../elements/emby-button/emby-button';
-import '../../../../elements/emby-checkbox/emby-checkbox';
-import '../../../../elements/emby-select/emby-select';
-import { getDefaultBackgroundClass } from '../../../../components/cardbuilder/cardBuilderUtils';
+import { CATEGORY_LABELS } from 'apps/dashboard/features/plugins/constants/categoryLabels';
+import { getDefaultBackgroundClass } from 'components/cardbuilder/cardBuilderUtils';
+import loading from 'components/loading/loading';
+import globalize from 'lib/globalize';
+
+import 'components/cardbuilder/card.scss';
+import 'elements/emby-button/emby-button';
+import 'elements/emby-checkbox/emby-checkbox';
+import 'elements/emby-select/emby-select';
 
 function reloadList(page) {
     loading.show();
@@ -23,27 +25,22 @@ function reloadList(page) {
 }
 
 function getHeaderText(category) {
-    category = category.replace(' ', '');
-    // TODO: Replace with switch
-    if (category === 'Channel') {
-        category = 'Channels';
-    } else if (category === 'Theme') {
-        category = 'Themes';
-    } else if (category === 'LiveTV') {
-        category = 'LiveTV';
-    } else if (category === 'ScreenSaver') {
-        category = 'HeaderScreenSavers';
+    const categoryKey = category.replaceAll(' ', '');
+
+    if (CATEGORY_LABELS[categoryKey]) {
+        return globalize.translate(CATEGORY_LABELS[categoryKey]);
     }
 
-    return globalize.translate(category);
+    console.warn('[AvailablePlugins] unmapped category label', category);
+    return category;
 }
 
 function populateList(options) {
     const availablePlugins = options.availablePlugins;
     const installedPlugins = options.installedPlugins;
 
     availablePlugins.forEach(function (plugin, index, array) {
-        plugin.category = plugin.category || 'General';
+        plugin.category = plugin.category || 'Other';
         plugin.categoryDisplayName = getHeaderText(plugin.category);
         array[index] = plugin;
     });

diff --git a/src/strings/en-us.json b/src/strings/en-us.json
@@ -54,6 +54,7 @@
     "AlwaysRemuxFlacAudioFilesHelp": "If you have files that your browser rejects to play or where it inaccurately calculates timestamps, enable this as a workaround.",
     "AlwaysRemuxMp3AudioFilesHelp": "If you have files that your browser inaccurately calculates timestamps, enable this as a workaround.",
     "AndOtherArtists": "{0} and {1} other artists.",
+    "Anime": "Anime",
     "AnyLanguage": "Any Language",
     "Anytime": "Anytime",
     "ApiKeysCaption": "List of the currently enabled API keys",
@@ -1181,6 +1182,7 @@
     "Movie": "Movie",
     "MovieLibraryHelp": "Review the {0}movie naming guide{1}.",
     "Movies": "Movies",
+    "MoviesAndShows": "Movies and Shows",
     "MusicAlbum": "Music Album",
     "MusicArtist": "Music Artist",
     "MusicLibraryHelp": "Review the {0}music naming guide{1}.",