fix: failing Docker images from CI #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
jellyfin-bot
added
the
ci
jellyfin-bot
removed
the
ci
|
The issue is only reproducible when using docker buildx |
For some reason, the client throwed an error about incorrect attribute when using Docker buildx's docker-container driver. The build worked flawlessly when using the normal docker build command (which is now an alias to docker buildx build, but with the docker driver) and in the host system using normal commands, and that's why it went unnoticed. Really strange error... Perhaps something encoding related in the outputted files? Either way, this commit fixes it by removing the trailing double quotes from the component!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merge of #2539, the Docker builds from CI stopped working properly. However, local and Codespace builds (even locally built Docker images) still are working fine, so no idea what's going on. This PR is a playground to test stuff since it can only be reproduced in CI-produced artifacts. When the fix is found, this same PR is going to contain the fixes.