Update server when video is in state finished
#1941
Merged
+29
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2024
|
@roidy I added a commit to simulate hitting the back button when state is finished. Can you give that a test? Here's the new build https://github.com/jellyfin/jellyfin-roku/actions/runs/11087045525?pr=1941 |
jimdogx
reviewed
Sep 28, 2024
|
@roidy the problem in your video should be fixed. I had the wrong api endpoint. https://github.com/jellyfin/jellyfin-roku/actions/runs/11087871463?pr=1941 |
This was
linked to
issues
Sep 29, 2024
jimdogx
approved these changes
Sep 29, 2024
cewert
commented
Sep 29, 2024
| @@ -623,7 +637,6 @@ sub onState(msg) | |||
|
|
|||
| ' Stop playback and exit player | |||
| m.top.control = "stop" | |||
| m.top.backPressed = true | |||
There was a problem hiding this comment.
m.top.backPressed wasn't being observed or used so I removed them
cewert
force-pushed
the
report-finished-state
branch
from
472fd42
to
c906457
Compare
cewert
added a commit
to cewert/jellyfin-roku
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
Fixes #1814