Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded API call and fix LoadVideoContentTask crash #1874

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 28, 2024

Remove unneeded API call and fix app crash when AboutMe() returns invalid. Comes from roku.com crash log:

Crashlog:

i                <uninitialized> 
jsonresponse     <uninitialized> 
resp             <uninitialized> 
url              <uninitialized> 
playdefault      <uninitialized> 
preferredlanguage <uninitialized> 
m                roAssociativeArray refcnt=3 count:2 
global           Interface:ifGloba$1 streams          Invali$1 Local Variables: 
   file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(39) 
#0  Function loaditems() As Voi$1 file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(527) 
#1  Function findpreferredaudiostream(streams As Dynamic) As Intege$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/ItemGrid/LoadVideoContentTask.brs(527)

which points to this line after running build-prod on 2.1.2:

preferredLanguage = m.user.Configuration.AudioLanguagePreference

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 28, 2024
@cewert cewert requested a review from a team as a code owner July 28, 2024 03:01
@cewert cewert changed the title Remove unneeded API call and fix LoadVideoContentTask crash (2) Remove unneeded API call and fix LoadVideoContentTask crash Jul 28, 2024
@cewert cewert merged commit a93c893 into jellyfin:2.1.z Aug 3, 2024
13 checks passed
@cewert cewert deleted the fix-loadvideocontenttask-crash2 branch August 3, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants