Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoadVideoContentTask crash #1873

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 28, 2024

Prevent crash by ensuring data is valid. Comes from roku.com crash log:

Crashlog:

subtitle         <uninitialized> 
subtitletracks   <uninitialized> 
safesubs         <uninitialized> 
subtitles        <uninitialized> 
m                roAssociativeArray refcnt=5 count:4 
global           Interface:ifGloba$1 meta             roSGNode:ChannelData refcnt=2 
video            roAssociativeArray refcnt=3 count:4 
Local Variables: 
   file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(47) 
#0  Function loaditems() As Voi$1 file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(55) 
#1  Function loaditems_videoplayer(id As String, mediasourceid As Dynamic, audio_stream_idx As Integer, forcetranscoding As Boolean) As Dynami$1 file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(131) 
#2  Function loaditems_addvideocontent(video As Object, mediasourceid As Dynamic, audio_stream_idx As Integer, forcetranscoding As Boolean) As Voi$1 file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(362) 
#3  Function addsubtitlestovideo(video As Dynamic, meta As Dynamic) As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/ItemGrid/LoadVideoContentTask.brs(362)

which points to this line after running build-prod on 2.1.2:

subtitles = sortSubtitles(meta.id, m.playbackInfo.MediaSources[0].MediaStreams)

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 28, 2024
@cewert cewert requested a review from a team as a code owner July 28, 2024 02:25
@cewert cewert merged commit e2c390a into jellyfin:2.1.z Jul 31, 2024
13 checks passed
@cewert cewert deleted the fix-loadvideocontenttask-crash branch July 31, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants