Add function to load default subtitles according to user settings on the global player #1306
Conversation
|
Leaving this as a draft for now. Definitely need some code cleanups and solve an issue where the subtitles don't load when the user presses next video. |
|
Have you been able to get the next video default subs working? Let me know if you need help on this. |
|
I have, actually. I've been using my branch as my daily driver for about a week now and found no issues with the subtitles. |
There was a problem hiding this comment.
This isn't working for me.
I have:
Preferred subtitle language: English
Subtitle mode: Only Forced
Burn subtitles: Auto
But when I play a movie, even though it shows "Forced" as selected, it's not actually showing any subtitles. If I select "None" and then re-select "Forced", it shows subtitles but not in English.
I then tried the release build 1.6.6 and even though I had to manually select "Forced", it played them correctly in English.
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired. |
Changes
Modified video player to mimic behavior of jellyfin web player, where subtitles load immediately when the video is loaded, according to user settings. Returns old functionality mentioned in #850.
Sets selectedSubtitleIndex to default subtitle.
Apologies for the duplicated PR, thought this would take longer.
Might also help with #1259, as this might remove some of the dependency on the system settings for captions
Issues
Fixes #850