Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to get the Jellyfin app working on my TV and in the server logs I was seeing a lot of errors about objects being in the wrong state and not being able to parse URL host names. The invalid state messages are a Jellyfin bug where it throws the wrong type of exception when it fails to download an image. The URL host name problem turned out to be because my password contained special characters and they weren't being escaped when building URLs.
I changed my password to a simpler one but it still didn't work. Jellyfin wasn't sending the username and password from the URL. There are two problems here. First, it doesn't send basic authentication when credentials are provided in the URL and, second, Tvheadend by default doesn't accept basic authentication anymore. I made
LiveTvService
implementIDynamicImageProvider
and it still doesn't work without telling Tvheadend to accept basic authentication, but now I have images loading and no errors are displayed when trying to watch a channel.That doesn't seem like fixing some image load errors should have fixed video playback in the TV app, but it just worked.