Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safe area insets in fullscreen mode #606

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

thornbill
Copy link
Member

Fixes the left/right safe area insets being used in fullscreen mode

Fixes #377 (in conjunction with jellyfin/jellyfin-web#6453)

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Jan 21, 2025
@thornbill thornbill added this to the v1.6.0 milestone Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.12%. Comparing base (9e67f5e) to head (63baec5).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
screens/HomeScreen.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
+ Coverage   60.00%   60.12%   +0.12%     
==========================================
  Files          47       47              
  Lines         945      948       +3     
  Branches      188      187       -1     
==========================================
+ Hits          567      570       +3     
  Misses        343      343              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thornbill thornbill merged commit c5786fa into jellyfin:master Jan 21, 2025
9 checks passed
@thornbill thornbill deleted the fix-safe-area branch January 21, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Development

Successfully merging this pull request may close these issues.

Ignore safe area in fullscreen mode
2 participants