Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffmpeg extension to ExoPlayer #488

Closed
wants to merge 2 commits into from

Conversation

maulik9898
Copy link

Audio codec supported : Vorbis, Opus, FLAC, ALAC, PCM/WAVE (μ-law, A-law), MP1, MP2, MP3, AMR (NB, WB), AAC (LC, ELD, HE; xHE on Android 9+), AC-3, E-AC-3, DTS, DTS-HD, TrueHD
Video codec supported : H.265 HEVC, MPEG-4 SP, VP8, VP9, AV1

@Maxr1998
Copy link
Member

Maxr1998 commented Aug 6, 2021

Thanks for your contribution! I'm not a fan of have a pre-packaged binary library in the repo, so we'll probably have to change some things. But it's a good start already, will make it easier for me to properly implement it.

@Maxr1998 Maxr1998 changed the title Added support for exoplayer ffmpeg extension. Add ffmpeg extension. Aug 6, 2021
@Maxr1998 Maxr1998 changed the title Add ffmpeg extension. Add ffmpeg extension to ExoPlayer Aug 6, 2021
@Maxr1998 Maxr1998 self-requested a review August 6, 2021 23:53
@Maxr1998 Maxr1998 added enhancement New feature or request exoplayer Related to the ExoPlayer integration labels Aug 6, 2021
@maulik9898
Copy link
Author

Just a quick question. According to exoplayer documentation, it supports SSA/ASS type subtitles. Then why it is not enabled.

@nielsvanvelzen
Copy link
Member

ExoPlayer doesn't really support ssa/ass subtitles, it only shows the text from them and ignore syling/animation etc. That's why we do not enable it.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 14, 2021
@Maxr1998
Copy link
Member

Maxr1998 commented Sep 4, 2021

Update: we published a pre-built extension on mavenCentral, and integrated it to the app with #520. Thus, this PR can be closed now. Thanks again for the contribution!

I'll cherry-pick the one missing change about the TS packet size later after evaluating it.

@Maxr1998 Maxr1998 closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration merge conflict Conflicts prevent merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants