replace with button #240
Open
replace with button #240
+380
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jech
reviewed
Jan 11, 2025
| @@ -473,7 +472,7 @@ textarea.form-reply { | |||
| } | |||
|
|
|||
| .collapse-video { | |||
| left: 30px; | |||
| left: calc(-100vw); | |||
There was a problem hiding this comment.
Can you please explain what that does?
jech
reviewed
Jan 11, 2025
| /* on top of everything */ | ||
| z-index: 2999; | ||
| top: 0; | ||
| right: 0; | ||
| height: calc(var(--vh, 1vh) * 100); | ||
| overflow-x: hidden; | ||
| overflow-y: hidden; | ||
|
|
||
| } | ||
| .sidenav.invisible { |
There was a problem hiding this comment.
We already have .invisible, so isn't this redundant?
jech
reviewed
Jan 11, 2025
| @@ -1154,17 +1153,21 @@ header .collapse:hover { | |||
| cursor: pointer; | |||
| overflow: hidden; | |||
| white-space: pre; | |||
| display: block; | |||
jech
reviewed
Jan 11, 2025
| @@ -4170,11 +4170,13 @@ document.getElementById('disconnectbutton').onclick = function(e) { | |||
| }; | |||
|
|
|||
| function openNav() { | |||
| document.getElementById("sidebarnav").style.width = "250px"; | |||
| //document.getElementById("sidebarnav").style.width = "250px"; | |||
There was a problem hiding this comment.
Please don't leave commented-out code. Why is this being removed?
jech
reviewed
Jan 11, 2025
| } | ||
|
|
||
| function closeNav() { | ||
| document.getElementById("sidebarnav").style.width = "0"; | ||
| //document.getElementById("sidebarnav").style.width = "0"; |
There was a problem hiding this comment.
Please don't leave commented-out code.
jech
reviewed
Jan 11, 2025
| // return; | ||
| // } else { | ||
| // openNav(); | ||
| // } |
There was a problem hiding this comment.
Please don't leave commented-out code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html file has now button instead of div, ...
At one place the replacement what not possible (volume with vol on/off + slider)
The aspect and function for the web page with button don't change.