refactor: del redundant ToDo comments

jdi-testing · May 28, 2024 · 2bdc2b3 · 2bdc2b3
1 parent 8cbd283
commit 2bdc2b3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 15 deletions.
diff --git a/src/features/locators/locators.slice.ts b/src/features/locators/locators.slice.ts
@@ -171,13 +171,11 @@ const locatorsSlice = createSlice({
       state,
       { payload }: PayloadAction<{ elementId?: ElementId; priority: LocatorCalculationPriority; ids?: ElementId[] }>,
     ) {
-      // ToDo: fix legacy naming
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       const { elementId, ids, priority } = payload;
       if (elementId) locatorsAdapter.upsertOne(state, { elementId, priority } as ILocator);
       if (ids) {
-        // ToDo: fix legacy naming
-        // eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-shadow
+        // TODO: fix legacy naming
+        // eslint-disable-next-line @typescript-eslint/no-shadow
         const newValue: Partial<ILocator>[] = ids.map((elementId) => ({ elementId, priority }));
         locatorsAdapter.upsertMany(state, newValue as ILocator[]);
       }
@@ -216,8 +214,6 @@ const locatorsSlice = createSlice({
       locatorsAdapter.upsertMany(state, locators.map(({ elementId }) => ({ elementId, isGenerated })) as ILocator[]);
     },
     setJdnHash(state, { payload }: PayloadAction<{ elementId: ElementId; jdnHash: string }>) {
-      // ToDo: fix legacy naming
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       const { elementId, jdnHash } = payload;
       locatorsAdapter.upsertOne(state, { elementId, jdnHash } as ILocator);
     },
@@ -249,16 +245,13 @@ const locatorsSlice = createSlice({
       // ToDo isGenerated refactoring
       const locator = typeof payload === 'string' ? simpleSelectLocatorById(state, payload) : payload;
       if (!locator) return;
-      // ToDo: fix legacy naming
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       const { isGenerated, elementId } = locator;
       locatorsAdapter.upsertOne(state, { elementId, isGenerated: !isGenerated } as ILocator);
     },
     toggleLocatorIsChecked(state, { payload }: PayloadAction<string>) {
       const locator = simpleSelectLocatorById(state, payload);
       if (!locator) return;
-      // ToDo: fix legacy naming
-      // eslint-disable-next-line @typescript-eslint/naming-convention
+
       const { isChecked, elementId } = locator;
       locatorsAdapter.upsertOne(state, { elementId, isChecked: !isChecked } as ILocator);
     },

diff --git a/src/features/locators/reducers/addCustomLocator.thunk.ts b/src/features/locators/reducers/addCustomLocator.thunk.ts
@@ -29,8 +29,7 @@ export const addCustomLocator = createAsyncThunk(
     let foundElementText;
     let originalCssSelector = '';
     let fullXpath = '';
-    // ToDo: fix legacy naming
-    // eslint-disable-next-line @typescript-eslint/naming-convention
+
     const elementId = `${generateId()}_${pageObjectId}`;
 
     if (getLocatorValidationStatus(message) === ValidationStatus.SUCCESS) {

diff --git a/src/features/locators/reducers/changeLocatorElement.thunk.ts b/src/features/locators/reducers/changeLocatorElement.thunk.ts
@@ -13,8 +13,6 @@ type ChangeLocatorElementPayload = ChangeLocatorAttributesPayload;
 export const changeLocatorElement = createAsyncThunk(
   'locators/changeLocatorElement',
   async (payload: ChangeLocatorElementPayload, thunkAPI) => {
-    // ToDo: fix legacy naming
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     const { locatorValue, elementId, locatorType, ...rest } = payload;
 
     const state = thunkAPI.getState() as RootState;

diff --git a/src/features/locators/reducers/identifyElements.thunk.ts b/src/features/locators/reducers/identifyElements.thunk.ts
@@ -103,7 +103,6 @@ export const onLocatorsCreated: Middleware = (store) => (next) => (action) => {
     const { generateXpath, generateCssSelector } = selectAutoGeneratingLocatorTypes(state as RootState);
     // generateCssSelector: false because it's run with attributes generation for performance reasons
     // ToDo: take generateCssSelector from selectAutoGeneratingLocatorTypes, when backend will be ready
-    // console.log('generateCssSelector: ', generateCssSelector); // LOG
     // @ts-ignore
     store.dispatch(runLocatorsGeneration({ locators, generateXpath, generateCssSelector }));
   }