-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Async API client #45
Draft
jbusecke
wants to merge
23
commits into
main
Choose a base branch
from
new-request-scheme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken what I have learned from #42 and written a completely new logic to get info from the ESGF API.
This one is a bunch simpler, not async, and seems to actually get a lot more URL information (tested with the cases in #42).
I think the design here can also accomodate leap-stc/cmip6-leap-feedstock#147 in general. It might also be relevant to leap-stc/cmip6-leap-feedstock#133 (if we want to inject dataset level tracking ids).
Ill test drive this over at the CMIP6 feedstock and will then finish up over here.
This seems to work really well so far. I had a few hangs, but after actually raising timeouts, and catching them, things seem to work fine.
Will have to finish up the things below, but am already starting to use this on the CMIP recipe.
Migrate the backoff/retry logic from the old async code-> Consider reimplementing the backoff/retry logic if needed #48