Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript trivia #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

klausbayrhammer
Copy link

This PR contains

  • upgrade to the typescript-version (2.9 -> 5.4)
  • exchanging the testing framework (from mocha, chai, sinon, nyc to vitest). This simplifies the mocking which might be used for golden master tests

@jbrains
Copy link
Owner

jbrains commented Aug 9, 2024

Thank you for the contribution! Since we intend this code base to be used for legacy code workshops, I have to ask you: do these changes make the Typescript code base "too modern"? For example, can the previous version of those tools still run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants