fix: support for graphviz v12.1.0 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
force-pushed
the
graphviz-fix
branch
3 times, most recently
from
6fa381e to
8e6875d
Compare
|
good thing we have that system font test. Looking into that test failure now. |
|
I also tested this locally with graphviz v11.0.0 and it still worked. Apparently, v12.0.0 through v12.1.0 were yanked from winget's distribution database. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 77.87% 77.83% -0.05%
==========================================
Files 68 68
Lines 8645 8647 +2
==========================================
- Hits 6732 6730 -2
- Misses 1913 1917 +4 ☔ View full report in Codecov by Sentry. |
|
The coverage report indicates that we are not testing with a font that does not have a weight of 400. 🙄 I'm ready to move on this if you are ok with my added changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.