Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect name for myst-example directive in docs #382

Closed
wants to merge 1 commit into from

Conversation

Bizordec
Copy link
Contributor

Name of the directive is myst-example, not md-example.

app.add_directive("myst-example", ResultsDirective)

Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

I'm not sure what to blame more: copy-n-paste or auto-complete... 😄

@2bndy5
Copy link
Collaborator

2bndy5 commented Aug 12, 2024

CI is failing for an unrelated reason. It looks like Graphviz v12.1.0 broke our usage on Windows (something about missing a config file). Investigating...

@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 4, 2024

Oops, I accidentally pushed the commit from this PR to main. I was trying to force-push a rebase of this remote's branch, but there was a branch name conflict (main).

@Bizordec In the future, please use a non-default branch for contributions from your fork; there's a multitude of reasons why this is considered "best practice" (with git).

@2bndy5 2bndy5 closed this Oct 4, 2024
@Bizordec
Copy link
Contributor Author

Bizordec commented Oct 4, 2024

Oh, okay.

Good thing it's just a minor fix in docs 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants