Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format_signatures: Fix whitespace issues and add tests #381

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

jbms
Copy link
Owner

@jbms jbms commented Aug 6, 2024

No description provided.

@jbms jbms force-pushed the fix-format-signatures-space branch from 8a8beba to d58344e Compare August 6, 2024 19:16
@jbms jbms requested a review from 2bndy5 August 6, 2024 19:16
@jbms jbms force-pushed the fix-format-signatures-space branch 2 times, most recently from b0b77a7 to 31c4c84 Compare August 6, 2024 19:51
@jbms jbms force-pushed the fix-format-signatures-space branch from 31c4c84 to af2303c Compare August 6, 2024 21:41
@jbms jbms requested a review from 2bndy5 October 4, 2024 05:14
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.38%. Comparing base (3c8fe16) to head (1b47224).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
sphinx_immaterial/apidoc/format_signatures.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   77.87%   81.38%   +3.50%     
==========================================
  Files          68       68              
  Lines        8645     8674      +29     
==========================================
+ Hits         6732     7059     +327     
+ Misses       1913     1615     -298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbms jbms merged commit 3c5d985 into main Oct 4, 2024
26 checks passed
@jbms jbms deleted the fix-format-signatures-space branch October 4, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants