Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/apigen: Fix support for pybind11 overloaded functions #378

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jbms
Copy link
Owner

@jbms jbms commented Aug 2, 2024

This was accidentally broken by
#357.

@jbms jbms requested a review from 2bndy5 August 2, 2024 22:54
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (9ec088e) to head (dda690b).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
sphinx_immaterial/apidoc/python/apigen.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #378       +/-   ##
===========================================
+ Coverage   67.19%   77.87%   +10.67%     
===========================================
  Files          68       68               
  Lines        8515     8645      +130     
===========================================
+ Hits         5722     6732     +1010     
+ Misses       2793     1913      -880     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its odd that the added test for this uses a pure python. Is it safe to assume pybind11 will generate bindings the same way in the future?

@jbms jbms force-pushed the fix-pybind11-overloaded-functions branch from 71a7dfd to 2d30620 Compare August 3, 2024 21:27
@jbms
Copy link
Owner Author

jbms commented Aug 3, 2024

Okay, I changed the test to use actual pybind11.

@jbms jbms force-pushed the fix-pybind11-overloaded-functions branch from 2d30620 to dda690b Compare August 6, 2024 05:31
@jbms jbms requested a review from 2bndy5 August 6, 2024 05:32
@jbms jbms merged commit 3c8fe16 into main Aug 6, 2024
26 checks passed
@jbms jbms deleted the fix-pybind11-overloaded-functions branch August 6, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants