[PATCH] warn instead of print for default color black message #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use warnings instead of print so end users can suppress outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per guidance on issue #18, I made changes to
error_handling.checkto handle both error exception and warnings. The single stray print statement incolors.pyhas been changed tocheckto be consistent with the rest of the package. I ran thefunctional_tests_logomaker.pyscript - everything passed.What does this change do?
"default color black" message is redirected to stderr instead of stdout. Users can use a one-liner from the warnings module to suppress this output which is useful for report generation.