Add icalendar 5.0 support and test against 5.0 and 6.x #160
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 91.88% 92.44% +0.56%
==========================================
Files 4 4
Lines 382 384 +2
Branches 93 94 +1
==========================================
+ Hits 351 355 +4
+ Misses 14 12 -2
Partials 17 17 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
…nd only test against 5.x and 6.x
This comment was marked as outdated.
This comment was marked as outdated.
DerDreschner
changed the title
|
The I set the setting with a local |
| @@ -5,30 +5,34 @@ on: | |||
| tags: | |||
| - '*' | |||
|
|
|||
| permissions: | |||
| contents: read | |||
There was a problem hiding this comment.
It's recommended by the setup-python action to set it to read. According to the GitHub documentation, the default would be none, which means that the whole action has no read permission to the content of the repository. I know it works without it for now, but well, if they they say it may not work, I introduced it here to be sure.
There was a problem hiding this comment.
good to know. thanks for pointing this out
| python -m pip install --upgrade pip | ||
| pip install poetry==2.0.1 | ||
| - name: "Install poetry" | ||
| uses: abatilo/actions-poetry@v3 |
There was a problem hiding this comment.
I am not a huge fan of extra deps in the build steps
There was a problem hiding this comment.
Mhm, yeah, I understand. But it's more readable in my opinion and when you look at the code of the action, it doesn't do a lot different then the code before. Main difference is the encapsulation of poetry from the global python environment inside the docker container by using pipx instead of pip.
If you feel better about it, I can revert the changes. But I would keep the separation in two build steps (install poetry itself - install the project dependencies).
There was a problem hiding this comment.
lets do that, than we can merge and publish
| pip install poetry==2.0.1 | ||
| poetry install | ||
| - name: Test with pytest | ||
| poetry add icalendar~=${{ matrix.icalendar-version }}.0 --no-interaction |
Support for
icalendar5.0 seems to be still wanted by @eigenmannmartin. This needs a little workaround to make it possible, which was discussed in the review process of #159. For housekeeping reasons, I prefer separate pull requests foricalendar5.0 support and test matrices for different Python versions.This pull request therefore adds
icalendar5.0 support and implements the test matrix. I also improved the pipelines a little bit.Fixes #147