Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_values_for_keys function to utils #607

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

FernandoKGA
Copy link
Contributor

Closes #344.

@FernandoKGA
Copy link
Contributor Author

@camilonova and @Mogost , could you guys take a look? In my opinion it solves the issue, not inside the Config as mentioned, but definitely a use case that I would particularly appreciate to reduce database access.

constance/utils.py Outdated Show resolved Hide resolved
@Natim
Copy link
Contributor

Natim commented Jan 13, 2025

The PR looks good to me, both comments are just nits

tests/test_utils.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (1451943) to head (52979b2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   84.23%   84.67%   +0.43%     
==========================================
  Files          21       21              
  Lines         736      744       +8     
  Branches      117      121       +4     
==========================================
+ Hits          620      630      +10     
+ Misses         83       82       -1     
+ Partials       33       32       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mogost Mogost merged commit 745fb6f into jazzband:master Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Option for multiget values
3 participants