feat: Add new Pathfinder 2e Creature layout (#436) #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous regex would match the following: ``` abilityMods: [4, 2, 3, -3, 1, -1] resistances: "[Some Link](note.md)" ``` So that that the first group (the link text) would match: ``` 4, 2, 3, -3, 1, -1]\n resistances: "[Some Link ``` and the second group (the path) would match: ``` note.md ``` This commit changes the regex so that it doesn't falsely match in these cases and instead just matches the actual markdown link.
11 tasks
pf2e.css generated from the Fantasy-Statblocks-CSS-Development repo
As far as I can tell this is never used anywhere and doesn't appear to have contents relevant to PF2e.
This allows conditional blocks to do things like check plugin settings and whether other plugins are enabled. In particular, this allows layouts to only show encounter buttons when the Initiative Tracker plugin is enabled.
Separates out the name and value into their own HTML elements rather than just rendered text so that we can style individual portions with CSS. This change has no visible effects - existing statblocks should look exactly the same.
This is instead of adding them to the text content itself. This allows layout authors to customize the appearance with CSS.
Thank you to MostTornBrain for valuable feedback! Most of this comes from there :) - Fix traits only showing when the trait property was present (even if alignment, size, or rarity was present) - Add sign (+/-) to perception modifier - Move Weaknesses before Resistances to match book layout - Don't show Initiative Tracker encounter buttons if Initiative Tracker isn't enabled - Show the initiative tracker view when the encounter buttons are pressed, to match the functionality of encounter buttons in the actual encounter blocks - Bold save names - Add sign (+/-) to ability modifiers
|
Hey @miscoined, this looks great. Is this meant to slot into existing PF2e creature stat blocks used by the TTRPG share? |
valentine195
requested changes
Aug 10, 2024
| @@ -926,6 +979,17 @@ class TableModal extends BasicModal<TableItem> { | |||
| this.block.calculate = v; | |||
| }); | |||
| }); | |||
| new Setting(el) | |||
| .setName("Do Not Add Property as CSS Class") | |||
There was a problem hiding this comment.
I usually try to prefer making these things perform the task rather than turning it off. Could you please refactor this setting to that?
| ] | ||
| } | ||
| ], | ||
| condition: "return plugin.app.plugins.enabledPlugins.has(\"initiative-tracker\");\n" |
There was a problem hiding this comment.
This is actually genius! Very clever.
| markdown: true, | ||
| headingProp: false, | ||
| heading: "", | ||
| callback: "var s = property.bonus < 0 ? \"-\" : \"+\";\ns += Math.abs(property.bonus);\nif (property.desc) {\n s += \" \" + property.desc\n}\nif (property.damage) {\n s += \", __Damage__ \" + property.damage\n}\nreturn s" |
There was a problem hiding this comment.
This will return NaN if property.bonus is undefined
|
Sorry I let this sit for so long; been a very busy summer. I appreciate the work you have been doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add a new default Pathfinder 2e Creature layout. See #436 for rationale and background. This adds this as a new layout, without replacing the existing Basic layout. I'm opening this as a draft PR for now until I finish adding documentation and layout restoration functionality - I thought early feedback would be useful in this case.
Changes Proposed
Related Issues
Progresses #436.
Checklist (WIP)
Screenshots (if applicable)
Will add later, before flipping this out of a draft PR