This repository has been archived by the owner on May 28, 2018. It is now read-only.
ParamConverterFactory should use LinkedHashSet to preserve ordering #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavelbucek As ordering of components is essential for applications to work correctly, I would kindly like to ask to include this PR in the next bugfix release of Jersey. :-) |
This was referenced Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
ParamConverterFactorymanages a list ofParamConverterProviderimplementations. But unfortunately the order in which the providers are processed seems to change between deployments. The reason for this is that the factory uses aHashSetinternally. The provider sets passed into the constructor areLinkedHashSetinstances, but as they are copied to theHashSet, the order may change.