Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes #97

Merged
merged 7 commits into from
Aug 15, 2019
Merged

Miscellaneous fixes #97

merged 7 commits into from
Aug 15, 2019

Conversation

jathak
Copy link
Owner

@jathak jathak commented Aug 15, 2019

Resolves #96.

This combines various bug fixes I've had floating around in various branches or my WIP editor changes, mostly JS interop fixes and type errors related to visualization that didn't get fixed after the #76. This includes the changes originally in #92.

This also bumps the minimum SDK to 2.4.0, mostly to get the new collection literal syntax added in 2.3. Various dependency versions are also bumped.

Copy link

@aaronchencal aaronchencal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! no red flags ;D

Copy link

@alexstennet alexstennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so you can merge (trusting aaron's review)

@jathak jathak merged commit 51ad227 into master Aug 15, 2019
@jathak jathak deleted the misc-fixes branch August 15, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualizing HOF errors with message related to minification
3 participants