Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bukuserver test cache #661

Merged
merged 5 commits into from
Jan 7, 2023

Conversation

rachmadaniHaryono
Copy link
Collaborator

@rachmadaniHaryono rachmadaniHaryono commented Jan 7, 2023

related #442

@jarun you hesitate to add new files to repo but this yaml recordings are important for test consistency.

@LeXofLeviafan mention that he also have diffculty on getting the same result #632

it doesnt mean direct network test is not possible or not needed but it is not the default

i think this test also failing several times, so maybe it is time to cache it

last thing, i added @LeXofLeviafan as reviewer. if you still have error on test i will change it

setup.py Outdated Show resolved Hide resolved
@LeXofLeviafan
Copy link
Collaborator

…The google search test is passing on my machine in this branch, for all Python versions.

Though there's two tests (test_buku.py::test_edit_rec & test_buku.py::test_sigint_handler) which get marked as "skipped" (the comment for the first one says "can't patch subprocess"), one more is apparently "deselected", and there's a bunch of deprecation warnings. Is this intended? If not, it should probably be rectified.

I think this test also failing several times

The current master didn't pass testing due to this test failing once (due to Google server DDoS detection)… and the same exact thing happened to my latest pull request 😂

@rachmadaniHaryono
Copy link
Collaborator Author

Is this intended? If not, it should probably be rectified

probably not, but the target for now just to make upstream test working again

The current master didn't pass testing due to this test failing once (due to Google server DDoS detection)… and the same exact thing happened to my latest pull request joy

i think this happen several time and the test have to to be manually restarted. so this should be never happen again

@LeXofLeviafan
Copy link
Collaborator

and the test have to to be manually restarted

Oh, right; there was such a feature on Github.

…I don't think I have access for that tho 😅

@jarun jarun merged commit fb8b15c into jarun:master Jan 7, 2023
@jarun
Copy link
Owner

jarun commented Jan 7, 2023

Thank you!

@LeXofLeviafan
Copy link
Collaborator

…An important note: this change isn't applied by tox correctly in a pre-existing repo clone until you delete the .tox/ subfolder (it tries to create new cassette files without substituting / characters in their names, for some reason).

@jarun
Copy link
Owner

jarun commented Jan 7, 2023

I don't understand. We don't have any .tox directory in buku repo.

@LeXofLeviafan
Copy link
Collaborator

Of course we don't – it's listed in .gitignore 😄

It's the local files created by tox on the first run (I think).

@jarun
Copy link
Owner

jarun commented Jan 7, 2023

I have added a cooking section in the ToDo list now: #484
We will use that to generate a release changelog.

Can you please add this note there?

@LeXofLeviafan
Copy link
Collaborator

You mean editing your comment? Or posting a new comment in the issue discussion?

@jarun
Copy link
Owner

jarun commented Jan 7, 2023

Please share what should the note be here.

@LeXofLeviafan
Copy link
Collaborator

"If you have a local repo clone, remove .tox/ subfolder if it's there before you run tests for the first time"

@rachmadaniHaryono rachmadaniHaryono deleted the feature/bukuserver-test-cache branch January 8, 2023 01:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants