Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Commit

Permalink
Do not try to build the container images when PR is closed (#150)
Browse files Browse the repository at this point in the history
At the time this job runs, the branch might have been deleted already,
causing unnecessary failures (+notifications for the PR owner) [1]:
```
A branch or tag with the name '$branch_name' could not be found
```

[1] https://github.com/janus-idp/operator/actions/workflows/pr-container-build.yaml?query=event%3Apull_request_target+is%3Afailure
  • Loading branch information
rm3l authored Jan 16, 2024
1 parent 8c097ff commit 9245561
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pr-container-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
# we are adding an 'authorize' job that checks if the workflow was triggered from a fork PR. In that case, the "external" environment
# will prevent the job from running until it's approved manually by human intervention.
pull_request_target:
types: [opened, synchronize, reopened, ready_for_review, closed]
types: [opened, synchronize, reopened, ready_for_review]
branches: [ main ]

concurrency:
Expand Down

0 comments on commit 9245561

Please sign in to comment.