Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC compilation and runtime fixes #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonahbeckford
Copy link

@jonahbeckford jonahbeckford commented Feb 11, 2024

Changes:

  1. Fix MSVC runtime error:

    Fatal error: cannot load shared library dllshexp_bigstring_io_stubs
    Reason: Cannot resolve send
    
  2. Fix MSVC compilation error:

    Local variable `char* buf` is overloaded with parameter `value buf`
    
    bigstring_io_stubs.c(44): error C2082: redefinition of formal parameter 'buf'
    bigstring_io_stubs.c(74): error C2082: redefinition of formal parameter 'buf'
    
  3. Likely ancient refactor missed Windows code ... no src variable.

Testing

$ opam exec --switch Y:\source\dksdk-type -- dune utop process-lib/src

────────────────────────────────────────────────────────────────────────────────┬──────────────────────────────────────────────────────────────┬────────────────────────────────────────────────────────────────────────────────                                                                                │ Welcome to utop version 2.13.1 (using OCaml version 4.14.0)! │                                                                                                                                                                └──────────────────────────────────────────────────────────────┘

Type #utop_help for help about using utop.

─( 19:41:45 )─< command 0 >──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────{ counter: 0 }─
utop # open Shexp_process;;
─( 19:41:45 )─< command 1 >──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────{ counter: 0 }─
utop # eval (run {|C:\Program Files\Git\cmd\git.exe|} ["status"]) ;;
On branch v0.16-msvc
Your branch is ahead of 'origin/v0.16-msvc' by 1 commit.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean
- : unit = ()

1. Local variable `char* buf` is overloaded with parameter `value buf`

bigstring_io_stubs.c(44): error C2082: redefinition of formal parameter 'buf'
bigstring_io_stubs.c(74): error C2082: redefinition of formal parameter 'buf'

2. Likely ancient refactor missed Windows code ... no `src` variable.

Signed-off-by: Jonah Beckford <[email protected]>
1. Fatal error: cannot load shared library dllshexp_bigstring_io_stubs
Reason: Cannot resolve send

Signed-off-by: Jonah Beckford <[email protected]>
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants